-
Notifications
You must be signed in to change notification settings - Fork 246
feat(auto-update-manager): show a system prompt about mismatched arch on apple arm on application start COMPASS-9592 #7133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… on apple arm on application start
| void dialog | ||
| .showMessageBox({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the performance issue is bad enough that it deserves a system prompt and not a toast or something similar, but I'm open to the feedback here
| return dl.download( | ||
| BrowserWindow.getAllWindows()[0], | ||
| `https://compass.mongodb.com/api/v2/download/${this.autoUpdateOptions.version}/compass/${this.autoUpdateOptions.channel}/darwin-arm64` | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll change this to shell.openExternal I think, it's so slow that the in-app download is misbehaving
|
Tests are still running, but I tried it with a build from the branch and it feels like it works pretty well, so I think this is ready for review now. If you're on macOS with an arm chip, you can try it yourself by downloading the x64 build from this URL, installing and running it. It will first prompt you to start download, then will automatically open installer when download is finished. One caveat is that we don't notarize PR builds, so don't forget to allow the app in the "Settings > Privacy & Security" (the flow is a bit awkward, you need to open app at least once, agree that it can't be opened, only then it will appear in settings) |
We saw an unexpected uptick in the issues related to people running x64 build of Compass on arm64 MacOS machines and the performance of Compass running through rosetta is really really bad. As a quick attept to mitigate this, we want to add the warning propmpt on the application start to direct users to download.
Draft because I need CI to build a version to test it, but the queue there is blocked terribly at the moment